search

thefrontside / ember-let

Create variable bindings inside your handlebars templates
MIT License
52 stars 16 forks source link

We need AST transform tests #24

Open taras opened 7 years ago

taras commented 7 years ago

I've been experimenting with inline let and it behaves unpredictably. There could be something wrong with the AST transform code. We need to add node tests for it.

rwjblue commented 7 years ago

They will just be super brittle. We need to focus on testing the things we care about, which in this case is whatever thing at runtime that you noticed was wrong.

mmun commented 7 years ago

Do you have an example? The AST transform is fairly straightforward and only touches stable parts of the AST so I would be surprised if it broken in any version. It seems more likely that helper runtime code is malfunctioning.