search

thefrontside / ember-let

Create variable bindings inside your handlebars templates
MIT License
52 stars 16 forks source link

Load after ember-cli-shims #37

Closed jurgenwerk closed 6 years ago

jurgenwerk commented 7 years ago

Since ember-cli-shims is not a bower dependency anymore, it loads later, causing the ember module to not be available to add-ons that rely on it.

rwjblue commented 7 years ago

Awesome, looks like this passes for Ember 2.12 (current release branch), but the changes in glimmer internals cause it to fail on 2.13-beta.

cibernox commented 7 years ago

I installed this this branch but I still get the same error:

Could not find module glimmer-runtime

Ember 2.13 Ember-cli 2.13.0-beta.4

rwjblue commented 7 years ago

Yep, like I said above, this patch works for Ember 2.12 (and is technically correct) but some changes are needed to support 2.13.

krasnoukhov commented 6 years ago

Is there anything I can help with to get this working with 2.13? @rwjblue can you elaborate what the problem is? Thank you!

rwjblue commented 6 years ago

https://github.com/thefrontside/ember-let/pull/38 added support for 2.13 and was released in 0.6.0.

I believe this issue should be closed...

krasnoukhov commented 6 years ago

Thanks, I'll give it a try then!