Fix Ember 2.15+ - Githubissues

thefrontside / ember-let

Create variable bindings inside your handlebars templates

MIT License

52 stars 16 forks source link

Fix Ember 2.15+ #45

Closed HeroicEric closed 6 years ago

HeroicEric commented 6 years ago

This is mostly stolen from https://github.com/thefrontside/ember-let/pull/43 (tanks @rwjblue :))

I made a few changes to get this passing.

Moved version checker initialization out of init because it was getting clobbered somehow?? and undefined within setupPreprocessorRegistry
Added a workaround to ensure /vendor is transpiled (see https://github.com/ember-cli/ember-cli/issues/7505)
Updated ember 2.15+ version to include support for multiple params ({{#let "foo" "bar" as |foo bar|}})

Robdel12 commented 6 years ago

It's Christmas! 🎉

yarigpopov commented 6 years ago

We need this update to update ember-sparkles

Robdel12 commented 6 years ago

Thanks @HeroicEric!! This was a much needed PR. I merged it in and cut a git tag, but I don't have permissions to release on NPM. Someone from @thefrontside/staff will have to do that.

yarigpopov commented 6 years ago

Thanks a lot! Looking forward for npm release

Robdel12 commented 6 years ago

Going to ping @cowboyd / @cafreeman since they've done publishing on this package before.

yarigpopov commented 6 years ago

Hello @cowboyd / @cafreeman (or somebody else from @thefrontside/staff ) We would really appreciate if you publish 0.7.0 version to npm

cherewaty commented 6 years ago

0.7.0 published to NPM (sorry for the delay, we had to sort out org permissions).