upgrade to typescript 4, upgrade eslint and add esModuleInterop true

thefrontside / javascript

Frontside JavaScript tooling

9 stars 5 forks source link

upgrade to typescript 4, upgrade eslint and add esModuleInterop true #16

Closed dagda1 closed 4 years ago

dagda1 commented 4 years ago

We want to set "esModuleInterop": true for all packages to avoid the import * from 'blah'; ambiguity.

This PR also

upgrades typescript to version 4
updates eslint
~~adds ts-node and @frontside/eslint-config as direct dependencies of @frontside/typescript~~

cowboyd commented 4 years ago

@dagda1 adds ts-node and @frontside/eslint-config as direct dependencies of @frontside/typescript

We need to confirm that we can invoke the ts-node executable within a monorepo for both the case where it is hoisted to the root as well as when it is in `packages/foo/node_modules/@frontside/typescrcript/node_modules/ts-node
There is a whole rigamarole @frontside/eslint-config and the way it resolves plugins that we need to slog through:

jnicklas commented 4 years ago

Should we merge this?

dagda1 commented 4 years ago

@jnicklas I would like to, to get rid of those import * imports and typescript 4 has no breaking changes. I did an upgrade in another contract yesterday.

The Typescript maintainers don't do semver for some weird reason.

@cowboyd @minkimcello @taras ??

cowboyd commented 4 years ago

I say go for it

dagda1 commented 4 years ago

@cowboyd the deed is done!

dagda1 commented 4 years ago

@cowboyd shall I upgrade bigtest?