thefrontside / javascript

Frontside JavaScript tooling
9 stars 5 forks source link

Remove typescript and eslint from eslint-config's dependencies #6

Closed minkimcello closed 4 years ago

minkimcello commented 4 years ago

Motivation

In the process of learning how ESLint works and getting eslint-config to work, I was too quick to add a bunch of dependencies that may not be necessary for frontside/eslint-config.

Approach

It is my understanding that we need only the dependencies that are relevant to eslint-config so I should not have added typescript and eslint as those are things that people should add to their projects manually. It wouldn't make sense to install eslint-config but not eslint.

github-actions[bot] commented 4 years ago

The preview packages of this pull request have been published. Click on the following packages for instructions on how to install them:

@frontside/eslint-config --- Install using the following command: ```bash $ npm install @frontside/eslint-config@mk_remove-deps ``` Or update your package.json file: ```bash { "@frontside/eslint-config": "mk_remove-deps" } ``` ---
eslint-plugin-prefer-let --- Install using the following command: ```bash $ npm install eslint-plugin-prefer-let@mk_remove-deps ``` Or update your package.json file: ```bash { "eslint-plugin-prefer-let": "mk_remove-deps" } ``` ---

Generated by :no_entry_sign: dangerJS against 447f89329d2aa43b6dfa6e92e4773e6ffeea7c30

cowboyd commented 4 years ago

This might be a good case of making eslint and typescript peer dependencies.

minkimcello commented 4 years ago

@cowboyd in a situation like this how would I determine what the oldest version of typescript and eslint should be in peerDep?