Closed minkimcello closed 4 years ago
The preview packages of this pull request have been published. Click on the following packages for instructions on how to install them:
Generated by :no_entry_sign: dangerJS against 447f89329d2aa43b6dfa6e92e4773e6ffeea7c30
This might be a good case of making eslint
and typescript
peer dependencies.
@cowboyd in a situation like this how would I determine what the oldest version of typescript
and eslint
should be in peerDep?
Motivation
In the process of learning how ESLint works and getting
eslint-config
to work, I was too quick to add a bunch of dependencies that may not be necessary forfrontside/eslint-config
.Approach
typescript
andeslint
fromeslint-config
's dependencies.@typescript-eslint/eslint-plugin
,@typescript-eslint/parser
, andeslint-plugin-prefer-let
.It is my understanding that we need only the dependencies that are relevant to
eslint-config
so I should not have addedtypescript
andeslint
as those are things that people should add to their projects manually. It wouldn't make sense to installeslint-config
but noteslint
.