Closed minkimcello closed 4 years ago
The preview packages of this pull request have been published. Click on the following packages for instructions on how to install them:
Generated by :no_entry_sign: dangerJS against 5eb4678fecab39746e4971e44939022e911fb918
@cowboyd Hmm it seems eslint
can't reach in to grab eslint-config
from frontside/typescript
.
node_modules/
@frontside/typescript/
node_modules/
@frontside/eslint-config/
.eslintrc.json // extends: @frontside/eslint-config 👎
Should we then just make frontside/eslint-config
a peer dependency?
It looks like this is a known issue https://github.com/eslint/eslint/issues/3458#issuecomment-594979168 and that there is both a formal solution in the works and that there are a number of workarounds that we might be able to use in the mean time.
@cowboyd @frontside/typescript: "1.0.0-2925c09"
is the preview package that has a dependency of the eslint-config
with the patch.
Motivation
I assumed by having
frontside/eslint-config
in the dependency oftypescript
we'd be able to extend from it but that does not seem to be the case.Approach
~I added
eslintrc.json
to thefrontside/typescript
package to see if it'll allow me to install it to a different project and have its eslint be able to extend directly fromfrontside/typescript
~ This didn't work.This is a known issue and was requested as a feature of
eslint
but never actually implemented.So I tried this monkey patch but that didn't work either.
I did the following the finish off this PR:
eslint
peer dependency ineslint-config
. If you're installing eslint-config, you should have eslint. Why buy a car air freshner if you don't have a car?eslint-config
as peer dependency totypescript
.README.md
to `typescript.typescript
tov1.0.1
.eslint-config
tov1.1.2
..gitignore
from sub-packages because there's one at the root of monorepo.