Convert microstates into a monorepo

thefrontside / microstates

Composable state primitives for JavaScript

1.31k stars 53 forks source link

Convert microstates into a monorepo #399

Closed minkimcello closed 4 years ago

minkimcello commented 4 years ago

Motivation

We're going to consolidate the repositories of the microstates org into this monorepo and transfer ownership to @thefrontside.

Approach

Copied all the contents of this repository and put it into packages/microstates/ (minus the .js).
Added lerna.json, package.json, and .gitignore.
Note: Didn't need to use lerna to import because all the commit history is already here.
Maintaining CircleCI setup for test, lint, coverage, and coveralls but not yet running in a matrix. We will modify as we go or possibly move over to Github Actions to keep all checks on one platform.

cowboyd commented 4 years ago

Is the plan to use learn and not yarn workspaces? What's the relative tradeoff?

taras commented 4 years ago

Is the plan to use learn and not yarn workspaces? What's the relative tradeoff?

@minkimcello my idea was to only use lerna for lerna import. We shouldn't add it as a dependency unless there are other features that we want to use.

coveralls commented 4 years ago

Coverage decreased (-0.02%) to 98.724% when pulling 1d7d88d23aec7882e0bd7f00854e6ceb62dc6bd8 on mk/monorepo-conversion into 13d6472ee1f0e278cc9908f46a770b57aaa28ec0 on master.

github-actions[bot] commented 4 years ago

A preview package of this pull request has been published with the tag mk_monorepo-conversion. You can try it out by running the following command:

$ npm install microstates@mk_monorepo-conversion

or by updating your package.json to:

{
  "microstates": "mk_monorepo-conversion"
}

Generated by :no_entry_sign: dangerJS against 1d7d88d23aec7882e0bd7f00854e6ceb62dc6bd8