thefrontside / playhouse

Frontside's Backstage Portal
https://backstage.frontside.services/
25 stars 13 forks source link

fix(yaml-actions): Update entity by metadata name #347

Closed alodela closed 1 year ago

alodela commented 1 year ago

Motivation

The YAML actions support an entityRef argument to update an specific entity from the content, but the current implementation doesn't take into account when the entity name is provided under metadata.

Approach

Update the entity ref validation in the append and set operations to check for the name at root level and under metadata for each document.

Alternate Designs

Possible Drawbacks or Risks

TODOs and Open Questions

Learning

Screenshots

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: c929ea9ccc89cc4743977eee88dac98e76d2caae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------------------------------- | ----- | | @frontside/scaffolder-yaml-actions | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

taras commented 1 year ago

Your changes were released in @frontside/scaffolder-yaml-actions@0.2.3. Thank you for your contribution.