Scaffolder Root Object Validation And Step Scoped Validation

thefrontside / playhouse

Frontside's Backstage Portal

https://backstage.frontside.services/

25 stars 13 forks source link

Scaffolder Root Object Validation And Step Scoped Validation #352

Closed jbolda closed 1 year ago

jbolda commented 1 year ago

Motivation

Validation was running for every piece for formData regardless of the step. This led to some confusing errors especially if the user went back and forth in the form.

Additionally, when using a type: 'object', the async validation would not run at the root.

Approach

Wrote some tests for this hook, then checked each output. We reordered the conditions so object is handled first, and included handling the validation at the root.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: dd62c62ff9dfc7aa8aeabda1753834489116546c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | ----------------------------------------------- | ----- | | @frontside/backstage-plugin-scaffolder-workflow | Minor | | app | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

frontsidejack commented 1 year ago

📣 NOTIFICATION You are receiving this message because we did not publish any packages.

Generated by @thefrontside/actions