search

thefrontside / simulacrum

A simulation platform for use during testing, during development and for high-fidelity application previews
89 stars 14 forks source link

Caught error in run loop `task 13` after upgrading to Effection 2.0.0-beta.21 #134

Closed taras closed 2 years ago

taras commented 2 years ago

@chuckcarpenter reported this issue in Discord and @wKich was able to reproduce it.

Running Simulacrum triggers this error after upgrading to effection@2.0.0-beta.21. Rolling back to effection@2.0.0-beta.17 seems to restore functionality. I looked at our tests and it looks like we're not starting Simulacrum there. We should at least start the server and start the echo simulator.

cowboyd commented 2 years ago

I looked at our tests and it looks like we're not starting Simulacrum there. We should at least start the server and start the echo simulator.

We are definitely starting the simulacrum server in the tests, but this appears not to be sufficient enough in that this should have definitely been caught.

@wKich Can you post a reproduction of this?

taras commented 2 years ago

We are definitely starting the simulacrum server in the tests

Oh, right. I looked at CircleCI and missed the test run at the bottom of the page.

wKich commented 2 years ago

@cowboyd you can merge v0 to #114 and try to run a simulation server in the cypress integration tests

cowboyd commented 2 years ago

@wKich I rebased, but am still not able to reproduce the issue.

cowboyd commented 2 years ago

Note that the fix in https://github.com/thefrontside/effection/pull/571 will not actually fix the problem in simulacrum, but it should make it easier to diagnose. We still need to get a reproduction though.

wKich commented 2 years ago

@cowboyd I think it is also fixed. We prepared for the demo and you got the same error

cowboyd commented 2 years ago

Yeah, we released 2.0 and got a confirmation that the fix worked.