Add the ability to treat the # sign as a comment in host files

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Create appservers.hosts with hostnames or comments

What is the expected output? What do you see instead?
Bad line. Must be host[:port] [login]

What version of the product are you using? On what operating system?
Centos 5.5 pssh2.1.1

Please provide any additional information below.

Pssh cant reach server with hostname like as pssh -H server01 command
and pssh cant read hosts(which is created for pssh) file when line has comment.

Original issue reported on code.google.com by ozgurk...@gmail.com on 18 Oct 2010 at 11:59

[GoogleCodeExporter]

Would you please give some more detail about "Create appservers.hosts with 
hostnames or comments"?  Would you perhaps attach a file to make it clear what 
is expected?  Thank you.

Original comment by amcna...@gmail.com on 18 Oct 2010 at 4:04

[GoogleCodeExporter]

Hello,

Shortly, I cant use comments in host file. My host file is like that:

server_ip #server name as comment

But pssh gave bad line error with this host file. I think comments are 
important.

And second thing is these:

I cant use hostname with pssh altough I set /etc/hosts files.  For example:

pssh -H server00 df -h

This command returned these:
[1] 11:16:01 [FAILURE] server00 Exited with error code 255

Original comment by ozgurk...@gmail.com on 18 Oct 2010 at 4:16

[GoogleCodeExporter]

Thanks for the clarification.  I agree that being able to add comment lines in 
the hosts file would be a helpful feature.

For your second issue, I would recommend running "pssh -H server00 -i -v df 
-h", which will give a little more verbose output.  If this isn't enough to 
solve the problem, and if there still appears to be a problem with pssh, then 
please open a separate ticket for this issue.

Thank you for submitting this feature request.

Original comment by amcna...@gmail.com on 18 Oct 2010 at 7:07

• Changed state: Accepted
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Original comment by amcna...@gmail.com on 18 Oct 2010 at 7:08

• Changed title: Add the ability to treat the # sign as a comment in host files

[GoogleCodeExporter]

I will try verbose mode. Thanks.

Original comment by ozgurk...@gmail.com on 18 Oct 2010 at 7:34

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

So, I finally got a chance to look at this issue in detail, and it looks like 
the '#' for comments was always supposed to work, but there was a bug.  I've 
fixed this (commit 8fbad23).  Thanks for bringing this up, and please report 
any further problems you come across.

Original comment by amcna...@gmail.com on 10 Jan 2011 at 2:34

• Changed state: Fixed
• Added labels: Type-Defect
• Removed labels: Type-Enhancement

[GoogleCodeExporter]

Thanks a lot this is an important thing for huge networks :)

Original comment by ozgurk...@gmail.com on 10 Jan 2011 at 2:43