thegazelle-ad / gazelle-server

Server for front-end and editor tools of The Gazelle
MIT License
19 stars 8 forks source link

Add E2E tests for Admin Not Found #245

Closed emilgoldsmith closed 6 years ago

jaisal1024 commented 7 years ago

I picked this up, but I am confused where you would need to use this within the editor tools?

emilgoldsmith commented 7 years ago

Yeah I can see what you mean haha ;). Well this is probably the easiest one! Seems like we only render it for garbage routes.

What I'd probably do is in nightmarejs pseudocode

return getLoggedInState('/this/is/not/valid')
.wait('#not-found-page')

where you assigned the #not-found-page ID to the EditorNotFound page.

And that should be a sufficient test for this