thegazelle-ad / gazelle-server

Server for front-end and editor tools of The Gazelle
MIT License
19 stars 8 forks source link

Fully fixed the iframe tag issue in preview section #494

Closed nurpeiis closed 5 years ago

nurpeiis commented 5 years ago

Related Issue

closes #466

Description

I have change the css for admin page. I have added relative size, instead of absolute.

How Has This Been Tested?

The changes were tested by running the server before and after changes and putting the page in various sizes and after changes, it still acted desirably. This can be seen one screenshots below.

Screenshots (if appropriate):

Before:

53699422-76c4a900-3e01-11e9-99e2-aa8d04e4fba2

After:

53699424-79bf9980-3e01-11e9-9ae4-3236305e344e

Checklist:

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 6.951% when pulling d5d93373bfe5cd076cd7adb1add37f473b9d67ef on preview into 3390d4f0ff5b568f4e8e3570b8c3374048f08860 on master.

emilgoldsmith commented 5 years ago

Awesome, the pictures in the issue are great, for another time it makes even more sense sharing those pictures here in the pull request though

emilgoldsmith commented 5 years ago

Also remember to follow the PR template :)

navyasuri commented 5 years ago

Hey @nurpeiis , the changes look good to merge but as @emilgoldsmith mentioned, please follow the PR template. Could you maybe add the PR template answers as a comment, including a screenshot? :)

navyasuri commented 5 years ago

Also, make sure to connect your PR to the issue that it fixes. Just good practices all around.