Upgrade node-addon-api and typescript deps

thegecko / webbluetooth

Node.js implementation of the Web Bluetooth Specification

https://thegecko.github.io/webbluetooth/

MIT License

141 stars 21 forks source link

Upgrade node-addon-api and typescript deps #192

Closed Apollon77 closed 1 month ago

Apollon77 commented 2 months ago

This PR upgrades the node-addon-api and typescript deps and fixes anything needed, which is:

"Event" type checks is strickter now on TS
node-addon-api is only supporting LTS versions officially, so Github actions need to use nodejs 18

fixes #172 fixes #137

Apollon77 commented 2 months ago

@thegecko Please approve the workflow runs, so that I can see if anything runs as expected ... I did not wanted to tweak gha files that it also runs on my fork

Apollon77 commented 2 months ago

Oohh. I think whoever does that spawn needs to be adjusted. Windows changed security things and spawns need to use a special option

Apollon77 commented 2 months ago

Ok blocked by https://github.com/prebuild/prebuild/issues/324 ... this is formally not an issue of this PR but changes from windows OS level itself

Apollon77 commented 1 month ago

@thegecko Please approve build, this now includes the prebuild windows fix

Apollon77 commented 1 month ago

That looks good, so "ready for review"