search

thegecko / webbluetooth

Node.js implementation of the Web Bluetooth Specification
https://thegecko.github.io/webbluetooth/
MIT License
150 stars 23 forks source link

Upgrade SimpleBLE to 0.7.3 base #193

Closed Apollon77 closed 7 months ago

Apollon77 commented 7 months ago

This fixes the macos functionality. testd by getting hw adapter (see #189) and also device scanning

I chose https://github.com/OpenBluetoothToolbox/SimpleBLE/commit/646bf487d900a6ee3ab211fd319fbf37de77ff59 which is the 0.7.3 release commit

fixes #191

thegecko commented 7 months ago

Did you try running the test suite?

AFAIK we can't upgrade beyond v0.6.1 due to this: https://github.com/OpenBluetoothToolbox/SimpleBLE/issues/277

Apollon77 commented 7 months ago

which test suite you mean? Tell me and I do.

I just tried getting adapters and scanning for devices which was completely "not working" on macos in the 0.6 range before.

But Ok if more is broken then meehhh ...

Apollon77 commented 7 months ago

PS: If you mean the test suite for webbluetooth ... then no ... run now and yes red ... :-( I try now

Apollon77 commented 7 months ago

PS: test suite also fails on my macos with 0.6.1 ... soooo ... I was expecting to see what githib says :-) Thenlet me close the PR for now ...

thegecko commented 7 months ago

You may need to set up a device to run the tests https://github.com/thegecko/webbluetooth?tab=readme-ov-file#testing

Apollon77 commented 7 months ago

Yes I just realized this ... so I need to purchase a microbit device ... ;-)

Thank you for your patience with me :-) Was not that cklear wheile checking the readme

Apollon77 commented 7 months ago

microbit device ordered ... will test as soon as it has arrived