thegeeklab / ansible-later

Another best practice scanner for Ansible roles and playbooks
https://ansible-later.geekdocs.de
MIT License
111 stars 12 forks source link

[ANSIBLE0001] check on newer Cisco Modules #30

Closed tweippert closed 4 years ago

tweippert commented 4 years ago

Newer Cisco IOS/IOSXR/NX-OS use a config syntax which triggers ANSIBLE0001:

results in:

ERROR: [ANSIBLE0001] Standard 'Single tasks should be separated by empty line' not met: ... tasks/ios_ports.yml:10: missing task separation (required: 1 empty line)

It seems the Config syntax with the "-" triggers a false-positive!?

Will look into it, if i can fix it myself, but hadn't needed time.

xoxys commented 4 years ago

@tweippert Should be fixed in the latest docker image. Could you verify after CI has released the updated image?

tweippert commented 4 years ago

Checked it against the git version and it looks good. Seems to fix my issue :) Thanks for the quick response!

xoxys commented 4 years ago

Cool. Feel free to re-open the issue if you find some missing cases :)