search

thegenemyers / DALIGNER

Find all significant local alignments between reads
Other
138 stars 61 forks source link

Fix memcpy to overlapping memory #52

Closed pb-cdunn closed 7 years ago

pb-cdunn commented 7 years ago

fixes PacificBiosciences/DALIGNER#24

Eliminates valgrind warning and fixes Trace point sum != aligned interval with all compiler versions.

Maybe there is a real fix that is better, but this at least fixes the error.

pbjd commented 7 years ago

memcpy -> memmove: Good idea. May be a little slower, but certainly more robust

thegenemyers commented 7 years ago

Yes, it'll be in my next patch. Thanks for the get. -- Gene

On 11/17/16, 11:59 PM, Christopher Dunn wrote:

fixes PacificBiosciences/DALIGNER#24 https://github.com/PacificBiosciences/DALIGNER/issues/24

Eliminates valgrind warning and fixes |Trace point sum != aligned interval| with all compiler versions.

Maybe there is a real fix that is better, but this at least fixes the error.

    You can view, comment on, or merge this pull request online at:

https://github.com/thegenemyers/DALIGNER/pull/52

    Commit Summary

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/thegenemyers/DALIGNER/pull/52, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkkNvRIN1VJxGlX4TeseqGYs8BmiAkAks5q_NxogaJpZM4K160f.