warnings

[pb-cdunn]

fasta2DB.c: In function ‘main’:
fasta2DB.c:353:25: warning: ‘ng’ may be used uninitialized in this function [-Wmaybe-uninitialized]
             core  = Root(ng->name,".fasta");
                         ^
DB2fasta.c: In function ‘main’:
DB2fasta.c:168:20: warning: ‘ofirst’ may be used uninitialized in this function [-Wmaybe-uninitialized]
           { fprintf(stderr," %d reads\n",first-ofirst);
                    ^
DB2fasta.c:172:17: warning: ‘ofile’ may be used uninitialized in this function [-Wmaybe-uninitialized]
           fclose(ofile);
                 ^
quiva2DB.c: In function ‘main’:
quiva2DB.c:459:13: warning: ‘core’ may be used uninitialized in this function [-Wmaybe-uninitialized]
         free(core);
             ^
quiva2DB.c:460:13: warning: ‘path’ may be used uninitialized in this function [-Wmaybe-uninitialized]
         free(path);
             ^
quiva2DB.c:448:14: warning: ‘input’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     if (fgetc(input) != EOF)
              ^
quiva2DB.c:355:28: warning: ‘ng’ may be used uninitialized in this function [-Wmaybe-uninitialized]
                 core = Root(ng->name,".quiva");
                            ^
DB2quiva.c: In function ‘main’:
DB2quiva.c:110:28: warning: ‘ofirst’ may be used uninitialized in this function [-Wmaybe-uninitialized]
                   { fprintf(stderr," %d quivas\n",first-ofirst);
                            ^
DB2quiva.c:114:25: warning: ‘ofile’ may be used uninitialized in this function [-Wmaybe-uninitialized]
                   fclose(ofile);
                         ^
fasta2DAM.c: In function ‘main’:
fasta2DAM.c:356:25: warning: ‘ng’ may be used uninitialized in this function [-Wmaybe-uninitialized]
             core  = Root(ng->name,".fasta");

And by the way, if you use ARG_NON_NEGATIVE(RSDEV,"Read length standard deviation") instead of ARG_POSITIVE, everything still works, and simulator -s0 is allowed. Not a big deal, but why not?

[thegenemyers]

I've silenced all the warnings and allows -s0 for the simulator as your requested. I've got some major updates coming this week or next (I hope), and these changes will be committed then. Cheers, Gene

On 5/28/16, 6:57 AM, Christopher Dunn wrote:

fasta2DB.c: Infunction ‘main’: fasta2DB.c:353:25: warning: ‘ng’ may be used uninitializedin thisfunction [-Wmaybe-uninitialized] core = Root(ng->name,".fasta"); ^ DB2fasta.c: Infunction ‘main’: DB2fasta.c:168:20: warning: ‘ofirst’ may be used uninitializedin thisfunction [-Wmaybe-uninitialized] { fprintf(stderr," %d reads\n",first-ofirst); ^ DB2fasta.c:172:17: warning: ‘ofile’ may be used uninitializedin thisfunction [-Wmaybe-uninitialized] fclose(ofile); ^ quiva2DB.c: Infunction ‘main’: quiva2DB.c:459:13: warning: ‘core’ may be used uninitializedin thisfunction [-Wmaybe-uninitialized] free(core); ^ quiva2DB.c:460:13: warning: ‘path’ may be used uninitializedin thisfunction [-Wmaybe-uninitialized] free(path); ^ quiva2DB.c:448:14: warning: ‘input’ may be used uninitializedin thisfunction [-Wmaybe-uninitialized] if (fgetc(input)!= EOF) ^ quiva2DB.c:355:28: warning: ‘ng’ may be used uninitializedin thisfunction [-Wmaybe-uninitialized] core = Root(ng->name,".quiva"); ^ DB2quiva.c: Infunction ‘main’: DB2quiva.c:110:28: warning: ‘ofirst’ may be used uninitializedin thisfunction [-Wmaybe-uninitialized] { fprintf(stderr," %d quivas\n",first-ofirst); ^ DB2quiva.c:114:25: warning: ‘ofile’ may be used uninitializedin thisfunction [-Wmaybe-uninitialized] fclose(ofile); ^ fasta2DAM.c: Infunction ‘main’: fasta2DAM.c:356:25: warning: ‘ng’ may be used uninitializedin thisfunction [-Wmaybe-uninitialized] core = Root(ng->name,".fasta");

And by the way, if you use |ARG_NON_NEGATIVE(RSDEV,"Read length standard deviation")| instead of |ARG_POSITIVE|, everything still works, and |simulator -s0| is allowed. Not a big deal, but why not?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/thegenemyers/DAZZ_DB/issues/19, or mute the thread https://github.com/notifications/unsubscribe/AGkkNm9Mqv05VdFgfz-_nw4VHI3m4DGjks5qF8shgaJpZM4Io_t3.

[pb-cdunn]

Thanks.

Btw, I've had some interesting success from datander and REPmask. Hopefully we will have a chance to discuss that in person in Menlo Park. :smile: