search

thegetty / conserving-canvas

"Conserving Canvas", edited by Cynthia Schwarz, Ian McClure, and Jim Coddington
0 stars 0 forks source link

End portion of pub citations in the sidebar and about page are showing up in italics online #150

Closed geealbers closed 1 year ago

geealbers commented 1 year ago

When the url for a publication includes a sub-directory, the formatting of the Chicago and MLA citations is broken. The closing </em> tag that should follow the publication title, is instead added to the end of the full citation, making the title and everything after it italic.

Here's the the HTML output with url: 'https://www.getty.edu/publications/conserving-canvas/' set: 

<div class="cite-this">
  <span class="cite-this__heading"> Chicago </span>
  <span class="cite-this__text">
    Hackney, Stephen. “1. Understanding Structure, Changing
    Practice.” In
    <em>Conserving Canvas, by Cynthia Schwarz, Ian McClure, and Jim
      Coddington. Los Angeles: Getty Conservation Institute, 2023.
      https://www.getty.edu/publications/conserving-canvas/i-history/1/.
    </em></span>
</div>

<div class="cite-this">
  <span class="cite-this__heading"> MLA </span>
  <span class="cite-this__text">
    Hackney, Stephen. “1. Understanding Structure, Changing
    Practice.”
    <em>Conserving Canvas, by Cynthia Schwarz et al., Getty
      Conservation Institute, 2023,
      https://www.getty.edu/publications/conserving-canvas/i-history/1/.
      Accessed <span class="cite-current-date">DD Mon. YYYY</span>.
    </em></span>
</div>

When the url does not include a sub-directory, the placement of the closing </em> tag is correct:

<div class="cite-this">
  <span class="cite-this__heading"> Chicago </span>
  <span class="cite-this__text">
    Hackney, Stephen. “1. Understanding Structure, Changing
    Practice.” In <em>Conserving Canvas</em>, by Cynthia Schwarz,
    Ian McClure, and Jim Coddington. Los Angeles: Getty Conservation
    Institute, 2023. https://www.getty.edu/i-history/1/.
  </span>
</div>

<div class="cite-this">
  <span class="cite-this__heading"> MLA </span>
  <span class="cite-this__text">
    Hackney, Stephen. “1. Understanding Structure, Changing
    Practice.” <em>Conserving Canvas</em>, by Cynthia Schwarz et
    al., Getty Conservation Institute, 2023,
    https://www.getty.edu/i-history/1/. Accessed
    <span class="cite-current-date">DD Mon. YYYY</span>.
  </span>
</div>
geealbers commented 1 year ago

Fixed with 7bd3476