search

thegetty / crom

Python library to make creation of CIDOC CRM easier by mapping classes/predicates to python objects
Apache License 2.0
49 stars 16 forks source link

Add vocab.SalePriceStatement for text about selling price #119

Closed kasei closed 4 years ago

kasei commented 4 years ago

What do you think about this for including information about multiple price data in German sales?

azaroth42 commented 4 years ago

We have other types of actual prices that use similar terms to that. I would be worried that people use it in both places inadvertently and get things confused.

It might not be an actual acquisition, just a bid ... so probably not vocab.AcquisitionStatement. It's not a Valuation of something, just a statement about the price.

I think we should ask Patricia for a sibling for the other statement types, but we can use that for now.

kasei commented 4 years ago

Good point about it not always being a sale. Thoughts on a better name for a statement that might be about a sale or a bid?

kasei commented 4 years ago

A complication for turning MonetaryAmounts into LinguisticObject Statements: there can be bibliographic statements and notes attached to the original monetary amount object. Those don't seem like they could be attached directly to they payment as they are specific to the price/currency.

kasei commented 4 years ago

@azaroth42 how about just PriceStatement?

azaroth42 commented 4 years ago

PriceStatement with http://vocab.getty.edu/page/aat/300055694 as the classification?