Updates - Githubissues

thegetty / crom

Python library to make creation of CIDOC CRM easier by mapping classes/predicates to python objects

Apache License 2.0

49 stars 16 forks source link

Updates #121

Closed azaroth42 closed 4 years ago

azaroth42 commented 4 years ago

Turn off P181_has_amount (use only P90_has_value)
Allow multiple property_classified_as (per [non] discussion on SIG list)
Put in (unused as of now) forcing function for scoped contexts
Update vocab with new AAT terms
- Entry/Record
- Status Note
- Update erroneous label for SubHeading

kasei commented 4 years ago

Looks good, though I'm unclear what the scoped contexts stuff will be for.

azaroth42 commented 4 years ago

I was using it temporarily to try and scope value to be P181_has_amount within MonetaryAmount before deciding that was stupid (ontologically) and we should just use the super-propertyP90_has_value. But in adding the (admittedly trivial) change, I thought it better to leave it in with an empty set than to remove completely.