search

thegetty / crom

Python library to make creation of CIDOC CRM easier by mapping classes/predicates to python objects
Apache License 2.0
49 stars 16 forks source link

Brief meta type #129

Closed azaroth42 closed 4 years ago

azaroth42 commented 4 years ago

Per discussion in https://github.com/linked-art/linked.art/issues/296, it is more consistent to have brief-text as a metatype for the statement types, rather than as a sibling.

This change puts that in effect.

kasei commented 4 years ago

Any related tests?

azaroth42 commented 4 years ago

No existing ones change (or ... everything passes still). There probably should be a test that started failing ... will at least add one for metatyping generally, good call.

kasei commented 4 years ago

Ah. I figured some would be affected by this. New tests would be good, but otherwise this looks good.

azaroth42 commented 4 years ago

There is a test for metatypes already: https://github.com/thegetty/crom/blob/master/tests/test_vocab.py#L26

But clearly not one for adding brief text.