search

thegetty / crom

Python library to make creation of CIDOC CRM easier by mapping classes/predicates to python objects
Apache License 2.0
49 stars 16 forks source link

Improve reader, fix some tests #133

Closed azaroth42 closed 4 years ago

azaroth42 commented 4 years ago

Reader now works with add_attribute_assignment and conceptual parts. Also creates instances of vocab "extension" classes, rather than vanilla classes from the model with the right classifications. This is important for boundary checking, in case the test looks for the vocab class, rather than the classification.

Also fix some edge cases revealed by testing the reader on all the examples in linked art site, and add tests.

azaroth42 commented 4 years ago

@bluebinary This should now work to read in data into the internal object form crom uses. Let me know if there are any issues.