thegetty / crom

Python library to make creation of CIDOC CRM easier by mapping classes/predicates to python objects
Apache License 2.0
49 stars 16 forks source link

Changes for 6 2 6 #54

Closed azaroth42 closed 5 years ago

azaroth42 commented 5 years ago

Breaking Changes

EDIT: last commit renames it to the more intuitive assigned_property from the default. This came from updating documentation and looking at it in context.

PR adds/updates tests, vocab, model, data, utils functions for these changes.

Future Breaking Change Warnings

Members of the SIG present at Paris meeting unanimously agreed that E92 Spacetime Volume SHOULD NOT be a superclass of E4 Period and E18 Physical Thing. SIG process does not allow proposals to be ratified at the same meeting, and thus this will (hopefully) hit after the October SIG in Heraklion. Thus, if you have used P10 instead of P9, this will soon stop working. Probably this will not affect us at all.

The CRMSoc (social) extension will define a Payment class, that will replace linked art's internal payment class. This will be a breaking change at the RDF level (namespace change), but likely not the JSON. Timeframe is unknown but unlikely to be in the next 6 months.

Proposal to create a separate extension for ongoing states, be they social, mental or physical. This would replace linked art's internal Phase class, and likely change names but hopefully little disturbance to the structure. Timeframe is unknown but unlikely to be in the next 12 months.

abrin commented 5 years ago

Rob, Beyond the use of the ManMadeObject, are you aware of these breaking changes being used in the Provenance Index mapping scripts?

thanks

azaroth42 commented 5 years ago

I don't believe that the other changes affect the PIR work at the moment. The P177 one will in the future, but then it will be already changed :)