Handling extraction of dimension values with partial units

thegetty / crom

Python library to make creation of CIDOC CRM easier by mapping classes/predicates to python objects

Apache License 2.0

49 stars 16 forks source link

Handling extraction of dimension values with partial units #87

Open kasei opened 5 years ago

kasei commented 5 years ago

The provenance sales data has many records where dimensions are specified using only partial units. For example, "3' 7 1/2 x 3' 2 1/2" (specifying feet but not inches). Should cromulent.extract.normalize_dimension be updated to handle these cases, assuming that the second value is in the same system (metric, imperial, French) but one unit finer than the previous?

kasei commented 5 years ago

109538b has a proof of concept for being more accepting of this style of dimension with only partial units.

azaroth42 commented 5 years ago

That seems good to me. I don't think there's any other interpretation possible.