search

thegetty / crom

Python library to make creation of CIDOC CRM easier by mapping classes/predicates to python objects
Apache License 2.0
49 stars 16 forks source link

Production as a top-level model type? #96

Closed kasei closed 4 years ago

kasei commented 4 years ago

(DEV-2727)

In the pipeline code, we have Production as a top-level model type. However, the boundary check code has it as an embedded class:

https://github.com/thegetty/crom/blob/2578ff4678fbdd02356e6885498a3834eb335931/cromulent/vocab.py#L548

Which is the correct approach?

kasei commented 4 years ago

Production was removed as a top-level model in the pipeline code, and will be embedded within the HumanMadeObject data.