search

thegetty / egypt-classical-world

"Egypt and the Classical World," edited by Jeffrey Spier and Sara E. Cole
0 stars 0 forks source link

Misc fixes #37

Closed geealbers closed 2 years ago

geealbers commented 2 years ago

This closes the remaining open issues, and then made a couple additional fixes. @Erin-Cecele, please look this over and let me know if anything seems amiss or if you have any questions. thanks!

Erin-Cecele commented 2 years ago

Looks good. I approved but I do have two side questions: 1. is the class="pdf-two-column" something specially created for this publication? Or have you used it before? How is it different from just grid="2"? 2. I though this was a Museum publication and not the Conservation Institute? I've been a little confused about that from the get-go.

geealbers commented 2 years ago

Thanks.

class="pdf-two-column" is something I regularly add to custom.css. It will make the figure group stretch across both columns of the text in the PDF. I haven't actually done the css work or looked at the PDF output yet in this case, but I knew I was going to need that class eventually so added it while I was in there.

And it is a Museum book (it was their symposium) which I thought is what a put everywhere, but did I leave a GCI in there somewhere?

Erin-Cecele commented 2 years ago

Oops, nope. You're correct. I misread a correction. All good.