Closed Erin-Cecele closed 2 years ago
Hi Audrey.
I would keep the brackets, as I think that indicates where missing letters have been filled in to the inscriptions. We can always delete later, but with this author, I’d rather err on the side of keeping formatting.
Thank you!
From: Audrey Warne @.> Reply-To: thegetty/egypt-classical-world @.> Date: Monday, December 13, 2021 at 5:28 PM To: thegetty/egypt-classical-world @.> Cc: Laura diZerega @.>, Assign @.***> Subject: Re: [thegetty/egypt-classical-world] Update essay 7 .md, references.yml, and figures.yml based on revised text from author. (Issue #45)
For a smallcaps like this: [Empero[r] Caesar]{.smallcaps}
Do I keep the formatting within the [] as well? Or should I be replacing it with the letters only as in [Emperor Caesar]
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/thegetty/egypt-classical-world/issues/45#issuecomment-993070058, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKN3ZKIB37LO3AREUKX5UGLUQ2MVFANCNFSM5J7OUUIQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
I found a shortcode in the old essay version that I didn't see above:
"Coptic ⲛⲟⲩⲧⲉ “god”"
Should I include it in the revised version as well? Its in note 4 of the side 3 summary in the Commented reedition of the inscriptions on the Benevento obelisks section.
Great catch, Audrey! Yes, please include this shortcode in the revised version. This essay does include Coptic font. Thank you!
So glad you are working on this project! Many thanks, again.
From: Audrey Warne @.> Reply-To: thegetty/egypt-classical-world @.> Date: Monday, December 13, 2021 at 6:25 PM To: thegetty/egypt-classical-world @.> Cc: Laura diZerega @.>, Assign @.***> Subject: Re: [thegetty/egypt-classical-world] Update essay 7 .md, references.yml, and figures.yml based on revised text from author. (Issue #45)
I found a shortcode in the old essay version that I didn't see above:
Coptic ⲛⲟⲩⲧⲉ “god”
Should I include it in the revised version as well? Its in note 4 of the side 3 summary in the Commented reedition of the inscriptions on the Benevento obelisks section.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/thegetty/egypt-classical-world/issues/45#issuecomment-993095665, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKN3ZKIKTTN2QGRYNFJBTXLUQ2TJ7ANCNFSM5J7OUUIQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Hi there I'm having an issue with my commits. I've been submitting them, but they aren't able to be linked to this project or issue. I'm not sure if I have to do something with the branch I created, but I just want to make sure my edits are uploading correctly.
We currently have two of your commits up on GitHub, both from yesterday. You can see the status of your branch at https://github.com/thegetty/egypt-classical-world/commits/issue-45-AW. Are there other commits aside from these that you haven’t been able to push up?
Oh wonderful—those are the only two. For some reason I wasn't seeing my commits as linked to Egypt when I clicked through my GitHub desktop. Thanks for confirming!
Hi @audreywarne I noticed that you have already place the q-figure shortcodes in the essay. The reason that item appeared lower down the list is because when you go to convert author date to the q-cite shortcode, the regex pattern will look for curly brackets. This means it will try to convert your q-figure shortcodes to q-cite. You will either need to redo the q-figure shortcodes or you will need to do find and replace one at a time to make sure it doesn't convert anything incorrectly. Just a heads up.
Got it, thanks @erin-cecele !
I'm running into an error when I try to preview. Any advice @geealbers ?
Audreys-MacBook:egypt-classical-world audreywarne$ quire preview Launching preview server ℹ Navigate to http://localhost:1313 to see your changes. ℹ Press Control+C or type "quire stop" to stop the preview. node:events:368 throw er; // Unhandled 'error' event ^
Error: spawn node_modules/.bin/webpack ENOENT at Process.ChildProcess._handle.onexit (node:internal/child_process:282:19) at onErrorNT (node:internal/child_process:475:16) at processTicksAndRejections (node:internal/process/task_queues:83:21) Emitted 'error' event on ChildProcess instance at: at Process.ChildProcess._handle.onexit (node:internal/child_process:288:12) at onErrorNT (node:internal/child_process:475:16) at processTicksAndRejections (node:internal/process/task_queues:83:21) { errno: -2, code: 'ENOENT', syscall: 'spawn node_modules/.bin/webpack', path: 'node_modules/.bin/webpack', spawnargs: [ '--watch', '-d', '--progress', '--color', '--config', 'webpack/webpack.config.dev.js' ] }
@erin-cecele How would you like me to both replace and keep the references section? Should I make a copy like I've done with essay 7 and make the edits on the copied page?
Convert bibliography with regex and replace in references.yml (issue Tag author date references and format references.yml entries #14)
Keep original version of references.yml
@audreywarne if this is your first time previewing this project, run 'quire install' before 'quire preview'.
@audreywarne or you can just cut-and-paste all the chapter 7 references and save them wherever makes the most sense for you. I think the only reason I suggested keeping it was because of the one hieroglyph image that will need to corrected - Spalinger 2015.
Thanks for clarifying my references questions. I ran quire install and I still had the same error (along with a bunch of errors in the install process).
@audreywarne for your preview issue, in the Terminal output there's a reference to Node version 17.2.0, which if is what you have installed is too high for Quire and may be causing the issue. Check by running node --version
in your Terminal. If it comes back as anything higher than 14.18.1, reinstall Node with this package: https://nodejs.org/download/release/v14.18.1/node-v14.18.1.pkg.
When the install is complete, run npm install --global @thegetty/quire-cli
to reinstall Quire, and then in the project, delete the themes/default/node_modules
directory and run quire install
.
If preview still isn't working after that, or if you had the correct Node version from the start, run quire preview --verbose
and share the output. Hopefully there will be more info there we can diagnose.
I'm not seeing the themes/default/node_modules @geealbers
but I was running the wrong version of node and installed the correct one
@erin-cecele Correct any q-cite errors where the q-cite shortcode does not match the references.yml
This is something that needs to be done in preview, correct?
@ldizerega should some of the captions end in a period? I noticed none of the captions in the new doc have punctuation but some of the old captions did
@erin-cecele Correct any q-cite errors where the q-cite shortcode does not match the references.yml
This is something that needs to be done in preview, correct?
That is correct, Audrey. You'll catch errors because they'll appear as broken shortcodes in the preview. You should see them when browsing the Notes at the end of each essay.
Is preview working for you now that you installed the correct version of node?
@erin-cecele I haven't tried again because I wasn't able to find the document Greg told me to delete. Let me see if it works without deleting it.
it's working now! I will review the q cite short codes and any other errors in the morning!
Swetnam-Burland 2011 isn't being recognized on the essay page but that same short code is in the references—any advice? I copied and pasted the text from the references to make sure there weren't any hidden characters, but no luck.
Okay I fixed all the errors I could see, it was some sort of hidden character I guess.
Closed with PR #46. Thank you @audreywarne for all your amazing work!
@audreywarne Thank you so much for chatting with me today and for signing up to do all this work. Below is the list of changes that need to be made by Friday. For big questions, please respond in this issue. For small things, feel free to shoot me a quick email.
For example:
↓→ ***\@r Hwn n\<x\>t(?) \<nb.ty\> iTi*** ˹***m sxm***˺ ***bik nbw*** ˹***wsr rnp.w(t)***˺ ***aA nxt \<nsw.t bi.ty\>*** ˹***AW***˺***&QR&R K%R% nsw.t bi.ty &***˹***M***˺***\[&\]IN% anx D.t xbi in(.w) m tA.wy xAs.wt m ntyy.w r iy.t=f n.t Xnw \[!r\]***˹***m***˺
should be| ↓→ ***\@r Hwn n\<x>t(?) \<nb.ty> iTi ˹m sxm˺ bik nbw ˹wsr rnp.w(t)˺ aA nxt \<nsw.t bi.ty> ˹AW˺&QR&R K%R% nsw.t bi.ty &˹M˺\[&\]IN% anx D.t xbi in(.w) m tA.wy xAs.wt m ntyy.w r iy.t=f n.t Xnw \[!r\]˹m˺*** |
[Domitian]{.smallcaps}
should be<span class="smallcaps">Domitian</span>
[the King of Upper and Lower Egypt]{.ul}
should be<span class="underline">the King of Upper and Lower Egypt</span>
![](media/....}
images and follow Greg’s formatting For example:![](media/image16.emf){width="0.20833333333333334in" height="0.19444444444444445in"}
should be![](/img/figures/essay-07-inline/image16.svg)
references.yml
(issue #14)references.yml
references.yml
(issue #32)references.yml
text as a guideq-cite
shortcode (issue #27)q-cite
errors where theq-cite
shortcode does not match thereferences.yml
{FIG. 10 + caption (orthophoto of A/1)}
{FIG. 11 + caption (photo of B/1)}
{FIG. 12 + caption (A/1 and B/1 facsimile)}
{FIG. 13 + caption (side 1 hieroglyphs)}
should be
{{< q-figure-group grid="2" id="fig-7-10, fig-7-11" class="pdf-two-column" >}}
{{< q-figure-group grid="2" id="fig-7-12, fig-7-13" class="pdf-two-column" >}}
figures.yml
Here are the FINAL markdown files you should use to make these changes (this is the same as what I previously sent you).
11_Prada essay_final_tracked_CLEAN_13dec21_GA.md 11b_Prada bibliography_final_tracked_CLEAN_13dec21.md 11a_Prada captions_final_tracked_CLEAN_13dec21.md