thegetty / inventories-and-surveys

"Inventories and Surveys for Heritage Management", by David Myers and Janet Hansen
0 stars 0 forks source link

Page number in-line citation not working correctly?? #35

Closed Erin-Cecele closed 1 year ago

Erin-Cecele commented 1 year ago

The page number pop-up citation does not seem to be working correctly throughout the publication:

Heritage resource analysis and evaluation is a sequential process that is guided by the consistent application of field survey tools and methods ({% cite 'Howe 2008' '32' %}).

Screen Shot 2023-09-28 at 11 45 31 AM

According to the docs, only the page number should be hyperlinked:

Screen Shot 2023-09-28 at 11 44 48 AM
Erin-Cecele commented 1 year ago

This example of the display text citation (in chapter 8) is working correctly though:

{% cite 'State of New South Wales 2023' '' '2023' %}

Screen Shot 2023-09-28 at 11 51 27 AM
Erin-Cecele commented 1 year ago

Also, @geealbers is this the correct interpretation of the McCarthy citation?

Screen Shot 2023-09-28 at 11 54 05 AM
geealbers commented 1 year ago

@Erin-Cecele I think this is a problem with the docs, not the shortcode.

It makes sense to me that the whole citation and page number would be part of the link. And if a Quire user only wanted to a page number to link they could achieve that with:

Howe 2008, {% cite 'Howe 2008' '' '32' %}

And in fact, the v0 docs indicates that the whole thing would be part of the link, so I'm not sure why we changed it between v0 and v1. But let's update the docs and then close this issue. Thanks!

And yes, I think you interpreted that McCarthy citation correctly.

Erin-Cecele commented 1 year ago

I think this was just a misinterpretation on my part. I added the underline to make it clearer and apparently confused myself. Fixed with PR# https://github.com/thegetty/quire-docs/pull/701

Screen Shot 2023-10-06 at 4 06 27 PM