Closed geealbers closed 5 years ago
Thanks for the list, I've started working on some of these already. I'll wait on some of the other ones from @rtapales to clarify as they may cause other design related issues (ie: Navbar, Menu Interaction and Tooltip).
As far as the 'Resources' section, I thought we had decided to remove all submenus as it was going to interfere too much with content list backend and other times when pages are not titled like that, are we adding that back in?
Also for search - I've removed the header to better match the comp, also just to confirm, search text highlighting is being pushed to next release.
Oh good point about the Resources section. Though we have the Downloads list there now, so let's take those out. Then the contents pages will just be contents, and the Resources and Downloads will only be accessible in the menu. Thanks
And yes, search highlighting is pushed to the next release.
Finished most of these, the ones that are left are the ones that @rtapales needs to go over.
The hover controls for having the page counter appear is better now, but could we remove it from the other icons and text links up there so it's just the two large blank areas to either side? To me, having the page counter show up every time I wanted to page forward or open the menu was distracting. Ramon, what do you think?
Ramon had shown me some alternative graphics/gradients to use as a default for the cover before user customized it themselves. Let's look at those again and implement one.
Add new style from Ramon for popup tooltips
Fantastic, thanks @mantasandri!
@rtapales, on the second of the three items Mantas called out, I had some additional thoughts. For the cover graphic, keep in mind that ideally it would work with either of the two theme variants so maybe it uses the red and blue in a single gradient? Or is a third color that works with both? Also, I'd like to take whatever you use there and use it as the default cover graphic in both the EPUB and PDF outputs. So if you could provide a version at 8.5 x 11 proportions, that would be great. Right not the default graphic for those is sort of a weird book icon (I can't remember why).
Got the new graphic/gradient and design on the tooltip from @rtapales and they've both been implemented (https://github.com/gettypubs/quire-starter-theme/commit/44afe949aa8fa7a611df82d9a82d2a643d73ceb6). Just have this last issue:
The hover controls for having the page counter appear is better now, but could we remove it from the other icons and text links up there so it's just the two large blank areas to either side? To me, having the page counter show up every time I wanted to page forward or open the menu was distracting. Ramon, what do you think?
I've tried to implement it via CSS with hovers, can't seem to get it to function as desired using only CSS, but I'll keep playing with it to see if I can get a hit on the deadspace between the icons to trigger the affect.
Closing out with the most recent commit - https://github.com/gettypubs/quire-starter-theme/commit/c5fc6d067e592a4da4dfaf85301f36ea55e12a4f
Here are my general notes on the latest version of the theme. A mix of layout stuff as well as some interaction things that @rtapales will need to consult on. As I mentioned in email, I think there are also a number of style tweaks/fixes that need to be made to bring the theme in line with the wireframes, but I'll leave that to Ramon to detail for now.
I'm next looking at some things around the Figures, Style Variables and Layout Handling controls, and Accessibility. And I expect I'll post on them separately just to keep things contained.
Navbar
Menu
Search
Cover
Contents
Entry pages
General