thegetty / quire

A multi-package repository for the Quire multiformat publishing framework
https://quire.getty.edu/
BSD 3-Clause "New" or "Revised" License
98 stars 12 forks source link

Allow sort_as to override both full and id values for bibliographies #740

Closed geealbers closed 1 year ago

geealbers commented 1 year ago

Thank you for contributing to Quire! Please complete the form below to submit your pull request for review.

For the Title of this pull request, please use the format "Type/Issue-#: Brief description." For Type, the options are Fix, Feature, Docs, or Chore. Issue-# is only needed if this pull request addresses an exisiting issue.

Checklist

Please put an X within the brackets that apply [X].

Is this pull request related to an open issue? If so, what is the issue number?

Issue #739

Please briefly describe the goal of this pull request and how it may impact Quire's functionality.

To allow sort_as values to work for overriding the default bibliography sorting regardless of whether the biblio is sorting by the id value (as is the case when bibliography.displayShort is set to true), or by the full value.

Please describe the changes you made, and call out any details you think are particularly relevant for the Quire team to note in their review.

I updated the sortReferences.js filter to choose sort_as before id, just like it was already set to choose sort_as before full.

Does this pull request necessitate changes to Quire's documentation?

No.

Include screenshots of before/after if applicable.

Additional Comments