thegetty / quire

A multi-package repository for the Quire multiformat publishing framework
https://quire.getty.edu/
BSD 3-Clause "New" or "Revised" License
98 stars 12 forks source link

DEV-13813: Only write SVG symbol definitions to PDF output once #764

Closed anderspollack closed 1 year ago

anderspollack commented 1 year ago

@geealbers good catch, writing these SVGs for each section was an oversight, this should fix it

Thank you for contributing to Quire! Please complete the form below to submit your pull request for review.

For the Title of this pull request, please use the format "Type/Issue-#: Brief description." For Type, the options are Fix, Feature, Docs, or Chore. Issue-# is only needed if this pull request addresses an exisiting issue.

Checklist

Please put an X within the brackets that apply [X].

Is this pull request related to an open issue? If so, what is the issue number?

DEV-13813

Please briefly describe the goal of this pull request and how it may impact Quire's functionality.

We were including SVG symbol definitions to display CC license icons in PDF output, but they were being included before each <section> element

Please describe the changes you made, and call out any details you think are particularly relevant for the Quire team to note in their review.

Only write SVG symbol definitions for the first collection index

Does this pull request necessitate changes to Quire's documentation?

Include screenshots of before/after if applicable.

Additional Comments