search

thegetty / quire

A multi-package repository for the Quire multiformat publishing framework
https://quire.getty.edu/
BSD 3-Clause "New" or "Revised" License
93 stars 12 forks source link

Add screen-only stylesheet #814

Closed hbalenda closed 1 year ago

hbalenda commented 1 year ago

https://github.com/thegetty/quire-starter-default/pull/36 and https://github.com/thegetty/quire-starter-iiif/pull/9 should be merged first.

Since pagedjs reads styles with the @media screen media query and does not allow overriding position: fixed, we need to include a separate stylesheet that is only included in the site output.

See pagedjs issue https://gitlab.coko.foundation/pagedjs/pagedjs/-/issues/433

anderspollack commented 1 year ago

I think this totally works for now! I was trying to adjust the .quire-primary flex container and doing things like making the .quire-navbar fixed instead of position: sticky to remove the need for .quire-entry__content to be position: fixed, but that was affecting other layout styles in various small ways (like requiring some extra calculated margins) and it seems much better to not accidentally introduce regressions... at least until we can do the big style refactor / reimplement these layout flexboxes.