Open Erin-Cecele opened 1 year ago
Updates:
@Erin-Cecele I'm not sure if this is already included in your list above, but fullscreen buttons do not appear to work on any browser at the moment. Or maybe they're being factored out?
At any rate if you start any new quire pub and click a figure, the "fullscreen" button in the upper left does nothing and produces an error about classList
in the console. Happens on Safari 16.6 and Chrome 116. Tested today with quire-1.0-rc.14
@cbutcosk, thank you for reporting this. I just fired up a new project and noticed that neither the images in the "Introduction" or Figure 1 and Figure 2 in "I. American Photographs" go fullscreen when you click the button in the upper left.
However, in "Cat. 1" Figure 1.1 and Figure 1.2 do open in fullscreen when the button is clicked. Also, both main catalogue entry images also open just fine. Can you confirm if the entry page images are going fullscreen for you? I wonder if the issue is somehow tied to layout
type?
Oh and here's my work environment information:
[Project] quire-cli 1.0.0-rc.10 quire-11ty 1.0.0-rc.14 starter https://github.com/thegetty/quire-starter-default@2.6.0 [System] quire-cli 1.0.0-rc.10 node v18.16.0 npm 9.5.1 os Darwin 21.6.0
And I tested with Chrome 114 and Firefox 117 - same results.
@Erin-Cecele Yes confirming the entry page seems to work where the essay full screen buttons do not. I suspect your developers also need to add a Shadow DOM polyfill for Safari < 16.5 (mobile and desktop), which in this issue breaks in a slightly different way from the Chromium-based browsers.
Hi @cbutcosk, please note I have opened a separate issue to address the fullscreen bug you spotted. See: #849
Status update as of 10/11
printImage
not also src
- BACKLOGprintImage
file are incomplete in PDF and EPUB output - BACKLOGprintImage
should work in the table of contents grid - BACKLOGsrc
is no longer functional or needed - BACKLOGcanvasId
by default if one is not supplied along with the manifestId
? - BACKLOGOnly update as of 11/30 is "High-res images are included in _site even when not needed" is backlogged and not selected for development.
Before proceeding, make sure there isn’t an existing issue for this bug.
Expected Behavior
This story is to capture all issues related to the core functioning of basci IIIF zooming images.
We've pushed some assets and content to the
QA-iiif
branch of thequire-starter-iiif
repo as well to help with testing.printImage
not alsosrc
printImage
file are incomplete in PDF and EPUB outputprintImage
should work in the table of contents gridsrc
is no longer functional or neededcanvasId
by default if one is not supplied along with themanifestId
?Actual Behavior
N/A
Steps to Reproduce
N/A
Version Numbers
N/A
Web Browser
No response
Relevant Terminal/Shell Output
No response
Supporting Information
No response