thegetty / quire

A multi-package repository for the Quire multiformat publishing framework
https://quire.getty.edu/
BSD 3-Clause "New" or "Revised" License
101 stars 13 forks source link

Quire build breaks if no cover image is specified #844

Open geealbers opened 1 year ago

geealbers commented 1 year ago

Before proceeding, make sure there isn’t an existing issue for this bug.

Expected Behavior

I should be able to remove the image from the index.md cover file, and have the cover display with the color background and title typography alone.

Actual Behavior

Instead, when there is not image specified. And error is thrown on quire build which stops the build as imcomplete.

[vite:build-html] EISDIR: illegal operation on a directory, read
file: /Users/galbers/test-cover-image/.11ty-vite/index.html
[11ty] Encountered a Vite build error, restoring original Eleventy output to _site [Error: EISDIR: illegal operation on a directory, read] {
  errno: -21,
  code: 'PLUGIN_ERROR',
  syscall: 'read',
  pluginCode: 'EISDIR',
  plugin: 'vite:build-html',
  hook: 'transform',
  id: '/Users/galbers/test-cover-image/.11ty-vite/index.html',
  watchFiles: [
    '/Users/galbers/test-cover-image/.11ty-vite/contents/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/catalogue/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/about/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/contributors/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/bibliography/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/intro/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/catalogue/1/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/catalogue/2/index.html',
    '/Users/galbers/test-cover-image/.11ty-vite/essay/index.html',
    '\x00vite/modulepreload-polyfill',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/javascript/lightbox/index.js',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/javascript/modal/index.js',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/javascript/application/index.js',
    '/Users/galbers/test-cover-image/package.json',
    '/Users/galbers/test-cover-image/node_modules/lit/index.js',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/fonts/index.scss',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/styles/application.scss',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/styles/screen.scss',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/styles/custom.css',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/javascript/application/canvas-panel.js',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/javascript/application/soundcloud-api.min.js',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/javascript/application/accordion.js',
    '/Users/galbers/test-cover-image/_plugins/search/search.js',
    '/Users/galbers/test-cover-image/.11ty-vite/_assets/javascript/application/scroll-to-hash.js',
    '/Users/galbers/test-cover-image/node_modules/lit-html/directives/unsafe-html.js'
  ]
}
[11ty] Problem writing Eleventy templates: (more in DEBUG output)
[11ty] ENOTEMPTY: directory not empty, rename '/Users/galbers/test-cover-image/.11ty-vite' -> '_site' (via Error)
[11ty] 
[11ty] Original error stack trace: Error: ENOTEMPTY: directory not empty, rename '/Users/galbers/test-cover-image/.11ty-vite' -> '_site'
[11ty] Copied 2488 files / Wrote 10 files in 10.29 seconds (1029.0ms each, v2.0.1)

Steps to Reproduce

  1. Start a new project
  2. Delete the image: entry from content/index.md
  3. Run quire build

Version Numbers

[test-cover-image] quire-cli 1.0.0-rc.10 quire-11ty 1.0.0-rc.14 starter https://github.com/thegetty/quire-starter-default@2.6.0

[System] quire-cli 1.0.0-rc.10 node v18.16.0 npm 9.5.1 os Darwin 22.3.0

Web Browser

No response

Relevant Terminal/Shell Output

No response

Supporting Information

No response

Erin-Cecele commented 1 year ago

This issue is currently backlogged but will be addressed in time. In the meantime, the docs will be amended to warn users that build will break if the default cover images is deleted and left blank in the index.md file

Erin-Cecele commented 1 year ago

Adding a note that this issue needs to be tested to pinpoint where exactly the break is occurring.

Erin-Cecele commented 12 months ago

Confirming the build will break when: image: value is left blank, when the image: value is "", and when image: is removed completely. The build will work if the image itself has been deleted but the path is still listed as a value (image: spiral-overlay.png)

Erin-Cecele commented 3 months ago

updated to say this issue is still present in

quire-cli 1.0.0-rc.14 quire-11ty 1.0.0-rc.17