thegetty / quire

A multi-package repository for the Quire multiformat publishing framework
https://quire.getty.edu/
BSD 3-Clause "New" or "Revised" License
93 stars 12 forks source link

`{% contributors context=pageContributors format='bio' %}` lists all publication essays, not just for `pageContributors` #847

Open Erin-Cecele opened 12 months ago

Erin-Cecele commented 12 months ago

Before proceeding, make sure there isn’t an existing issue for this bug.

Expected Behavior

{% contributors context=pageContributors format='bio' %} should list all the contributors included in Page YAML, their individual bios, and their other essay contributions within the publication unless that contribution is the page the shortcode is being used on.

Actual Behavior

{% contributors context=pageContributors format='bio' %} lists the contributors included in that page's page YAML, their bios, and, erroneously, all the other essays by page YAML contributors throughout the publication as well as the essay the shortcode appears on.

Screen Shot 2023-09-14 at 1 20 30 PM

In the example above, Mahdi Sahragard only contributed the first essay. None of the other items in that list should be appearing.

Steps to Reproduce

  1. Add contributor info to the Page YAML of an essay
    contributor: 
    - first_name: Anneka  
    last_name: Lenssen
    bio: 
  2. Add the shortcode {% contributors context=pageContributors format='bio' %}

Version Numbers

[grj-19] quire-cli 1.0.0-rc.10 quire-11ty 1.0.0-rc.14 starter /Users/galbers/GitHub/quire-starter-default@2.6.0 [System] quire-cli 1.0.0-rc.10 node v18.16.0 npm 9.5.1 os Darwin 21.6.0

Web Browser

Chrome: Version 117.0.5938.62 (Official Build) (x86_64)

Relevant Terminal/Shell Output

No response

Supporting Information

I found that adding *** above the shortcode removed the list of essays:

***
{% contributors context=pageContributors format='bio' %} 
Erin-Cecele commented 11 months ago

This is similar to issue #853 - an issue inspired by an error in Inventories and Surveys: https://github.com/thegetty/inventories-and-surveys/issues/9. In this issue, the error was caused by context=publicationContributors.

Erin-Cecele commented 8 months ago

When I refer to "contributors included in that page's page YAML" I am referring to the contributors added with:

contributors
  - first_name: 
    last_name: 

This is separate from contributors listed in the publication.yaml and added via an id in the page YAML, which this issue does not appear to affect.