search

thegetty / quire

A multi-package repository for the Quire multiformat publishing framework
https://quire.getty.edu/
BSD 3-Clause "New" or "Revised" License
89 stars 10 forks source link

Fix/Issue-863: http check on toc image #874

Open rrolonNelson opened 9 months ago

rrolonNelson commented 9 months ago

Thank you for contributing to Quire! Please complete the form below to submit your pull request for review.

For the Title of this pull request, please use the format "Type/Issue-#: Brief description." For Type, the options are Fix, Feature, Docs, or Chore. Issue-# is only needed if this pull request addresses an exisiting issue.

Checklist

Please put an X within the brackets that apply [X].

Is this pull request related to an open issue? If so, what is the issue number?

863

Please briefly describe the goal of this pull request and how it may impact Quire's functionality.

This imitates the HTTP check in image-tag.js so that way we can pull an image src that has a full URL without it turning into a relative URL

Please describe the changes you made, and call out any details you think are particularly relevant for the Quire team to note in their review.

Does this pull request necessitate changes to Quire's documentation?

no

Include screenshots of before/after if applicable.

Additional Comments

I tried to get the alt text to be brought in properly as well but it doesn't seem to be working.

mphstudios commented 8 months ago

@rrolonNelson reviewing this solution locally we discovered that the change will break images for the epub output; until we can revisit the solution, if you do not need epub output, the change in this pull-request can be made directly to a local Quire publication.

rrolonNelson commented 8 months ago

change will break images for the epub output;

@rrolonNelson reviewing this solution locally we discovered that the change will break images for the epub output; until we can revisit the solution, if you do not need epub output, the change in this pull-request can be made directly to a local Quire publication.

Good catch. We are not currently using the epub. I will take another look and see if I can resolve the issue for the epub and update this PR.