search

thegetty / quire

A multi-package repository for the Quire multiformat publishing framework
https://quire.getty.edu/
BSD 3-Clause "New" or "Revised" License
89 stars 10 forks source link

when multiple objects are included on a catalogue page, only the last listed appears in the online view #876

Open KJustement opened 9 months ago

KJustement commented 9 months ago

Before proceeding, make sure there isn’t an existing issue for this bug.

Expected Behavior

A second object id (from object.yaml page) was added to a single catalogue page. It was expected that the additional object id would populate the catalogue page with that object image and data after the first object once the project was previewed/built.

Actual Behavior

Instead, once the project was built, the online version only showed the image for the second, new object id entered in the catalogue page. All text data associated with both object ids appeared online. In the catalogue grid view, that single catalogue page did show the first, original object id image as a thumbnail, however.

In the pdf format, however, almost everything operated as expected. In the grid view, the single catalogue page showed the first, original object id image as a thumbnail. The individual catalogue page showed the two images for both object ids in the correct order, and the relevant text data associated with both object ids populated the catalogue page. However, the title for the multi-object catalogue page was only populated with the data from the first, original object id (PDF attached). pagedjs.pdf Please see pages 5–8, with special attention to "Cat. 1"

Steps to Reproduce

Working from the Quire tutorial test project:

  1. Find a new object to utilize for the new catalogue entry. I went to the Getty's website and found an additional Dorothea Lange photograph.
  2. Download that image and add it to the _assets/figures/images folder as either a .jpg or .png
  3. In VSC, go to the _data/objects.yaml file and create a new object entry (with object id) using the object information from the Getty's website, following the format for the preexisting object entries.
  4. Go to the catalogue folder in VSC, create a new .md file (I labeled mine "3.md", given that there were already two catalogue entries).
  5. Following the format of the existing catalogue .md files, populate your new catalogue page.
  6. Go to the first, original catalogue page (in this case, "1.md"). Where you see the object id associated with this first catalogue page, enter the new object id from the objects.yaml file in the line below.
  7. Preview the project.
  8. Build the project and create a pdf.

Version Numbers

The "quire info --debug" command did not work in my project directory Terminal Saved Output.txt

Screenshot 2023-11-07 at 9 08 29 AM

Web Browser

Safari, version 16.6

Relevant Terminal/Shell Output

No response

Supporting Information

No response

Erin-Cecele commented 8 months ago

@KJustement the reason quire info --debug did not work is because you are using Quire v0. Are you testing this for a new Getty Quire project? Or an older one? Running the nvm command will help you switch between versions (nvm use 18 brings me to 1.0.0-rc.10 which is v1.)

Erin-Cecele commented 8 months ago

@mphstudios I'm removing the quire-11ty tag until we can confirm this is an issue in v1.

KJustement commented 8 months ago

@Erin-Cecele sorry, I realized that I am set to Quire v0 as default and ran the commands with that. However, I double checked the project settings and it is built from Quire v1. Here is the new quire info --debug result:

Screenshot 2023-12-04 at 1 49 42 PM
Erin-Cecele commented 8 months ago

Got it! Thanks for the update @KJustement!

Erin-Cecele commented 7 months ago

Tested by adding cat-3 to the project. Added a new image and then added new entries to the figures.yaml file and the objects.yaml file. Then added the new object id to both cat-1 and cat-2.