thegetty / quire

A multi-package repository for the Quire multiformat publishing framework
https://quire.getty.edu/
BSD 3-Clause "New" or "Revised" License
89 stars 10 forks source link

Old `{% ref %}`shortcode usage needs to be removed in default starter project #886

Closed Erin-Cecele closed 6 months ago

Erin-Cecele commented 8 months ago

Before proceeding, make sure there isn’t an existing issue for this bug.

Expected Behavior

When I create a new Quire project, I expect the figure callouts on the essay.md page (for example) to take me to the images they reference:

Screen Shot 2023-12-05 at 4 45 49 PM

I also expect that the Markdown is correct and can be used as a guide for creating new figure callouts of my own:

Screen Shot 2023-12-05 at 4 46 44 PM

Actual Behavior

Per @cbutcosk in issue #825, "ref produces an anchor link, but clicking does nothing and produces no console messages."

Steps to Reproduce

What actually needs to happen is the now outdated usage of the {% ref %} shortcode needs to be removed from the essay.md page and replaced with regular figure callouts such as (Figure 1)(#fig-1).

Version Numbers

[CLI] Command 'info' called with options { debug: true } [id-test] quire-cli 1.0.0-rc.10 quire-11ty 1.0.0-rc.16 starter https://github.com/thegetty/quire-starter-default@2.6.0 [System] quire-cli 1.0.0-rc.10 node v18.16.0 npm 9.5.1 os Darwin 21.6.0

Web Browser

Chrome 119.0.6045.199

Relevant Terminal/Shell Output

No response

Supporting Information

The default starter does have the correct usage of the ref shortcode included in the 1.md section. This just needs to be properly documented per #865 in the quire-docs repo.

Erin-Cecele commented 8 months ago

I have updated this issue for clarification.

Erin-Cecele commented 6 months ago

Closing this issue since the fix was completed with PR #41 in the default starter repo. I double-checked the fix by starting a new project.