DEV-16535: Add `is-land` to quire figures, `quire-figure.webc` regression fixes - Githubissues

thegetty / quire

A multi-package repository for the Quire multiformat publishing framework

https://quire.getty.edu/

BSD 3-Clause "New" or "Revised" License

89 stars 10 forks source link

DEV-16535: Add `is-land` to quire figures, `quire-figure.webc` regression fixes #893

Open anderspollack opened 7 months ago

anderspollack commented 7 months ago

Changed

Give addWebcShortcode a default value for attributeNames argument
Upgrade is-land to 3.0.2
Add support for formats: false
Wrap quire figure markup in <is-land>

Fixed

Figures styles broken with figures wrapped in elements DEV-16772
Empty
elements are being adding before and after
DEV-16773
Video and audio fallback links are displaying online DEV-16774
CLI errors with image sequences are breaking preview/build DEV-16775
Vite warning thrown in CLI on preview with new is-land work DEV-16777

anderspollack commented 6 months ago

@geealbers these fixes should all be good to go -- I had to do some corresponding style work on https://github.com/thegetty/quire-starter-default/pull/42 to account for the new DOM structure from the is-land elements.