search

thegetty / quire

A multi-package repository for the Quire multiformat publishing framework
https://quire.getty.edu/
BSD 3-Clause "New" or "Revised" License
88 stars 10 forks source link

Build error on `quire build` on `quire-11ty@1.0.0-rc.17` #907

Open cbutcosk opened 4 months ago

cbutcosk commented 4 months ago

Before proceeding, make sure there isn’t an existing issue for this bug.

Expected Behavior

After starting a new project with quire-cli@latest and quire-11ty@latest, using quire-starter-default@latest, I expect quire build to produce no errors.

Actual Behavior

A fresh project with quire-cli@1.0.0-rc.11, quire-cli@1.0.0-rc.17, quire-starter-default@2.9.0 produces this error after figures processing:

[quire] INFO     Figures:IIIF:Manifest          Generated manifest for figure "mother-annotations"
[quire] INFO     Figures                        Processing complete
ERROR Error: Check the dynamic attribute: `@html="component(id, image_dir)"`.
Original error message: caption is not defined
    at ModuleScript.evaluateScript (/Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/moduleScript.cjs:71:10)
    at async AstSerializer.evaluateAttribute (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:787:21)
    at async AstSerializer.getPropContentAst (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:820:17)
    at async AstSerializer.compileNode (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:1152:25)
    at async AstSerializer.getChildContent (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:349:56)
    at async AstSerializer.compileNode (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:1226:36)
    at async AstSerializer.getChildContent (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:349:56)
    at async AstSerializer.compileNode (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:1226:36)
    at async AstSerializer.getChildContent (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:349:56)
    at async AstSerializer.compileNode (file:///Users/incharge/Documents/Projects/weichbild/getty-quire-pdf/quire-pdf-firststeps/quire/test-pub/node_modules/@11ty/webc/src/ast.js:1226:36)

Steps to Reproduce

Version Numbers

[CLI] Command 'info' called with options { debug: true } [test-pub] quire-cli 1.0.0-rc.11 quire-11ty 1.0.0-rc.17 starter https://github.com/thegetty/quire-starter-default@2.9.0 [System] quire-cli 1.0.0-rc.11 node v21.6.2 npm 6.14.18 os Darwin 23.3.0

Web Browser

No response

Relevant Terminal/Shell Output

No response

Supporting Information

No response

cbutcosk commented 4 months ago

Meant to say -- AFAICT the build succeeds regardless in terms site-build contents and return code (which is also a little troubling tbh, it should stop the world and return not-0 I think?).