search

thegetty / rococo

"Rococo Ébénisterie in the J. Paul Getty Museum," by Gillian Wilson and Philippe Halbert
https://www.getty.edu/publications/rococo/
0 stars 0 forks source link

alt-text added for cat 3 and cat 4 #74

Closed audreywarne closed 3 years ago

audreywarne commented 3 years ago

Added in alt-text with Lilit's comments for the next two catalogue entries.

geealbers commented 3 years ago

Actually @audreywarne I just realized there's an issue here. When you copied the text in from Word, they came with curly quotes surrounding them. I think this is causing the site build to fail, and they should all be converted to straight quotes.

For example, this:

alt: “detail of the top of the cartonnier, showing the clock framed with gilt bronze mounts and four Chinese figures”

Should be:

alt: "detail of the top of the cartonnier, showing the clock framed with gilt bronze mounts and four Chinese figures"
audreywarne commented 3 years ago

ah eep. I've been copying and pasting since catalogue 2. So I should go back in and redo all of the quotation marks for cat 2-4? Should I start with 3/4 on the same branch I made the original changes in? Or create a new branch and do all the edits together?

From: Greg Albers notifications@github.com Sent: Thursday, January 28, 2021 10:44 AM To: thegetty/rococo rococo@noreply.github.com Cc: Audrey Warne AWarne@getty.edu; Mention mention@noreply.github.com Subject: Re: [thegetty/rococo] alt-text added for cat 3 and cat 4 (#74)

Actually @audreywarnehttps://github.com/audreywarne I just realized there's an issue here. When you copied the text in from Word, they came with curly quotes surrounding them. I think this is causing the site build to fail, and they should all be converted to straight quotes.

For example, this:

alt: “detail of the top of the cartonnier, showing the clock framed with gilt bronze mounts and four Chinese figures”

Should be:

alt: "detail of the top of the cartonnier, showing the clock framed with gilt bronze mounts and four Chinese figures"

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/thegetty/rococo/pull/74#issuecomment-769294383, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ744TFFDK7LCMOZEQZCETLS4GWATANCNFSM4WUBN5PQ.

geealbers commented 3 years ago

If you can make all the changes (to cat 2 as well) on this branch, that would be perfect.

geealbers commented 3 years ago

Perfect, that fixed it. Thank you! Going to merge this in now.