thegodenage / waffle

Web Application Firewall, made in go.
MIT License
96 stars 11 forks source link

Feature: Implement Graceful shutdown #21

Closed werniq closed 3 weeks ago

werniq commented 1 month ago

This PR introduces graceful shutdown functionality to the server. It ensures that the server properly handles shutdown signals (SIGINT, SIGTERM), stops accepting new requests, and allows ongoing requests to complete before shutting down. The update includes:

This change enhances the server's stability by ensuring a smooth and controlled shutdown process.

werniq commented 1 month ago

@cebilon123 while repairing CI/CD I've noticed that some tests took really long. After some investigation, I've reached to rule package. I'm not sure, but I can't see any usage of it in the Waffle.

Is it needed? Or maybe it will be used later?

werniq commented 1 month ago

@thegodenage what about rule package? It is not used in project, but tests from this package are failing. Can I remove it too?

werniq commented 1 month ago

@thegodenage Finally, CI is blue 🙂

werniq commented 1 month ago

@thegodenage where can we chat about helm? There are few things that I would like to know, before implementing it.

thegodenage commented 3 weeks ago

@werniq Hey sure, sorry for late response, have a lot of different stuff in the meantime regarding daytime job and apartment.