search

thegooddata / extension

GNU General Public License v3.0
0 stars 0 forks source link

Build a custom HTML confirmation modal/whatever #12

Closed JuanMenendezBuitrago closed 10 years ago

JuanMenendezBuitrago commented 10 years ago

When the user clicks on the "reset settings" button, javascript shows a browser-dependent confirmation pop-up which doesn't work as expected when the checkbox is selected. To deal with this, a custom HTML confirmation should be implemented, either as a modal or as a slide or any other way. Whatever suits best.

JuanMenendezBuitrago commented 10 years ago

I'm done with this. The only thing we have to consider now is a way to revert the setting for this when the user has checked the box "don't ask me for confirmation again". Maybe in an "options" page for this extension.

JuanMenendezBuitrago commented 10 years ago

extension-confirmation-alert extension-confirmation-question

JuanMenendezBuitrago commented 10 years ago

When the user clicks on "reset all settings" after the option "do not ask for confirmation" has been selected, only the message "local whitelist has been reset" is shown for 2 seconds and then disappears.

marcosmenendez commented 10 years ago

I see this box on top of the not working properly box instead than in the bottom of it.

Regarding the confirmation question, it is too complex. I would take out the Ok button, center the second message and make it disappear after 2 seconds. If the user has not click the check box, this message will appear again next time.

This setting should be stored as well as part of user preferences so it is not asked again everytime the user updates the extension

JuanMenendezBuitrago commented 10 years ago

If you want to remove the OK button and make the second message disappear automaticly after a couple of seconds, I would move the checkbox to the first question.

marcosmenendez commented 10 years ago

Ok

Marcos Menendez marcos@qustodian.com (+34) 677 494 035 C/Vilamari 50 08015 Barcelona www.qustodian.com

On Wed, Sep 17, 2014 at 5:21 PM, Juan notifications@github.com wrote:

If you want to remove the OK button and make the second message disappear automaticly after a couple of seconds, I would move the checkbox to the first question.

— Reply to this email directly or view it on GitHub https://github.com/thegooddata/extension/issues/12#issuecomment-55910092 .