search

thegooddata / extension

GNU General Public License v3.0
0 stars 0 forks source link

When the extension opens it shows different user level for a sec #32

Closed marcosmenendez closed 9 years ago

marcosmenendez commented 9 years ago

It shows the beginner icon until it updates to the actual level. It should be cached so the change does not happen every time the user opens the extension

marcosmenendez commented 9 years ago

The solution found is a quick fix. Now, it shows a blank space before showing the right icon, but it should show the right icon from the start in the same way it shows the number of pieces, etc.

This info should be cached as well

marcosmenendez commented 9 years ago

Just one remark. We should always try to minimize the amount of memory used by the extension. It is critical to minimise the impact on browsing experience. So we should make sure we don't store the image in the extension memory

JuanMenendezBuitrago commented 9 years ago

I see the issue is tagged as "in developement" but just in case, a possible solution would be to get the seniority level once from a function called in the background.js and store it instead of calling it from the popup.js. Therefore the value would be available when the user decides to open the popup and also we would save api calls since the seniority level is not likely to change during a single browsing session.

2015-05-12 10:18 GMT+02:00 Marcos Menendez notifications@github.com:

Just one remark. We should always try to minimize the amount of memory used by the extension. It is critical to minimise the impact on browsing experience. So we should make sure we don't store the image in the extension memory

— Reply to this email directly or view it on GitHub https://github.com/thegooddata/extension/issues/32#issuecomment-101185401 .

marcosmenendez commented 9 years ago

The same problem happens as well with the number of data points. If we want to get the very last number, then we should leave the space blank and then put the number, instead of putting a 0 and then the number

marcosmenendez commented 9 years ago

I moved to "in development" from "ready to test" by mistake. Nobody is working on it now. You can take it if you have time. Just change the owner.