search

thegooddata / extension

GNU General Public License v3.0
0 stars 0 forks source link

Hide "trade non sensitive queries" option #41

Closed marcosmenendez closed 9 years ago

marcosmenendez commented 9 years ago

Since we are not working with chango anymore, we should delete that line of the extension. This issue is linked to these other 2 of the webapp: https://github.com/thegooddata/webapp/issues/155 https://github.com/thegooddata/webapp/issues/158

JuanMenendezBuitrago commented 9 years ago

The extension part of this issue is done. Webapp related issues thegooddata/webapp#155 and thegooddata/webapp#158 are pending

atrandafir commented 9 years ago

Please be clear if we need to hide or remove. @JuanMenendezBuitrago had deleted it, I've put it back and just hidden it because as far as I understand from https://github.com/thegooddata/webapp/issues/158 we might bring the functionality back someday.

JuanMenendezBuitrago commented 9 years ago

I deleted it because I've came across of quite a few, legacy code that never gets executed, "just in case" and commented-out pieces and all in all it was getting a bit messy. It was easy to restore in case we needed it in the future anyway.

2015-05-23 14:48 GMT+02:00 Alexandru Trandafir Catalin < notifications@github.com>:

Please be clear if we need to hide or remove. @JuanMenendezBuitrago https://github.com/JuanMenendezBuitrago had deleted it, I've put it back and just hidden it because as far as I understand from thegooddata/webapp#158 https://github.com/thegooddata/webapp/issues/158 we might bring the functionality back someday.

— Reply to this email directly or view it on GitHub https://github.com/thegooddata/extension/issues/41#issuecomment-104889467 .