thegooddata / extension

GNU General Public License v3.0
0 stars 0 forks source link

Whitelist behavior #44

Open JuanMenendezBuitrago opened 9 years ago

JuanMenendezBuitrago commented 9 years ago

Currently, adding threats to the whitelist works on a per-domain basis. In other words, the threat is whitelisted for the domain in the active tab and remains blocked for the rest of domains. Thus, if the user considers that she has nothing against Google Adtracks for instantce, she has no way to whitelist it for every domain and should mark Google Adtracks as allowed every time.

This behavior is over-protective and should be changed

Whichever makes more sense and is easier to implement in code and in the UI.

JuanMenendezBuitrago commented 9 years ago

I've been working on this for a few days now along with #42. My intention was to work on it exclusively but somehow I found myself rewriting some parts and refactoring so I ended up working on both. I have finished with the whitelist and now I have to make sure everything else works the way it is supposed to.