thegooddata / webapp

TheGoodData web application
http://www.thegooddata.org
GNU General Public License v3.0
3 stars 2 forks source link

Session cookies not working in specific use cases #185

Open marcosmenendez opened 8 years ago

marcosmenendez commented 8 years ago

If I logout in the website and try to relogin as a different user, initial session persists

atrandafir commented 8 years ago

@marcosmenendez I've tried logging with both my username and the admin user and I can see it works fine for me. Can you provide more details on this?

marcosmenendez commented 8 years ago

You are right. Now it is working. Don't know why.

marcosmenendez commented 8 years ago

I have reproduced the error. It happens when you logout in the website. Logging out in the extension works.

JorgelieHD commented 8 years ago

@marcosmenendez can't reproduce this error. I logged in with the admin user, then my username and it seems fine. Tried this twice and works for me. Can you be more specific?

atrandafir commented 8 years ago

Maybe related to server side cache? I think when the sys admin did some tweaking on Nginx sometimes pages were cached, so maybe we should check that is not something like that.

El 1/12/2015, a las 16:54, jorgerayware notifications@github.com escribió:

@marcosmenendez can't reproduce this error. I logged in with the admin user, then my username and it seems fine. Tried this twice and works for me. Can you be more specific?

— Reply to this email directly or view it on GitHub.

calidadesystems commented 8 years ago

Hello, I have checked webserver configuratión, sessions are stored in files not in any kind of caches, and i don't saw any kind of cache in nginx One question, could be that sessions aren't being destroyed correctly?

http://7php.com/php-5-3-how-to-completely-destroy-session-variables-in-php/

//remove PHPSESSID from browser if ( isset( $_COOKIE[session_name()] ) ) setcookie( session_name(), “”, time()-3600, “/” ); //clear session from globals $_SESSION = array(); //clear session from disk session_destroy();

atrandafir commented 8 years ago

I know that maybe Adrian activated some kind of page-cache in nginx when we were doing stress tests, but again, this is just an idea that we must check along with other possibilities of the issue to see what could be the cause. If Marcos can reproduce this "live", maybe he can do a Skype with Jorge and maybe we can understand it better.

2015-12-01 18:32 GMT+01:00 Calidade Systems notifications@github.com:

Hello, I have checked webserver configuratión, sessions are stored in files not in any kind of caches, and i don't saw any kind of cache in nginx One question, could be that sessions aren't being destroyed correctly?

http://7php.com/php-5-3-how-to-completely-destroy-session-variables-in-php/

//remove PHPSESSID from browser if ( isset( $_COOKIE[session_name()] ) ) setcookie( session_name(), “”, time()-3600, “/” ); //clear session from globals $_SESSION = array(); //clear session from disk session_destroy();

— Reply to this email directly or view it on GitHub https://github.com/thegooddata/webapp/issues/185#issuecomment-161041519.

calidadesystems commented 8 years ago

I've seen this behavior several times, and causes were a varnish cache bad configured,or session errors. I've checked again and don't see any kind of cache, just nginx raw performance optimizations if we can reproduce this bug we can check what's happening in session printing a dump of session variable content.

marcosmenendez commented 8 years ago

I'm on skype to reproduce it now if you want

On Tue, Dec 1, 2015 at 7:00 PM, Calidade Systems notifications@github.com wrote:

I've seen this behavior several times, and causes were a varnish cache bad configured,or session errors. I've checked again and don't see any kind of cache, just nginx raw performance optimizations if we can reproduce this bug we can check what's happening in session printing a dump of session variable content.

— Reply to this email directly or view it on GitHub https://github.com/thegooddata/webapp/issues/185#issuecomment-161048641.