search

thegooddocsproject / thegooddocsproject.github.io

The Good Docs Project website
https://thegooddocsproject.dev/
Creative Commons Attribution Share Alike 4.0 International
19 stars 16 forks source link

Viraji patch 2 #35

Closed viraji closed 4 years ago

viraji commented 4 years ago

Changed nav bar to: Home | Licences | Community | Download | Press from: Home | About | Licences | Contribute | Contact Us as per Issue #14 described in: https://docs.google.com/document/d/1KVU44BA37tu-4DXYM99diCeqI6FeDiOFYQp5zLwl8vU/edit?usp=sharing

viraji commented 4 years ago

All changes in #14 done as per the agreed upon doc at: https://docs.google.com/document/d/1KVU44BA37tu-4DXYM99diCeqI6FeDiOFYQp5zLwl8vU/edit?usp=sharing

mgan59 commented 4 years ago

There were conflicts with index.md from master. I did a REBASE with a --force push. I'm assuming that these changes are final. But if you need/want to continue working on this branch you will need to rebuild your local branch.

mgan59 commented 4 years ago

github has a limit 10 megs, so broke up the review gifs.

Verification Top NavBar has relative links that work

good-docs-review-pr-35-part1

Verification of Community Page -- bunch of additional relative links to new pages (Roles, Decision Logs)

good-docs-pr-35-community

camerons commented 4 years ago

Provided my approval based on screenshots from Morgan, review of code changes, and my trust of Morgan's review process. (I don't have a local version to check.)

Loquacity commented 4 years ago

:rocket: