Adds cover image (and other small things)

Loquacity commented 3 years ago

ALL Pull-Requests require an associated Issue as documented in How to contribute.

Fixes: https://github.com/thegooddocsproject/templates/issues/173

Purpose / why

Adds an image to the cover of the interactive IA Guide

What changes were made?

Adds .svg and .png images to the images directory, and links it to the cover page of the interactive IA Guide.
Slight modifications to the GH Action to make it run effectively when a PR is created from a fork.
Adds a short note to the twine file for future contributors.

Verification

[ ] Check that the image is appropriate
[ ] Check that the image appears correctly.
[ ] Ensure checks have passed

Checklist

Pull-request reviewer should ensure the following

[ ] Are issues linked correctly?
[ ] Is this PR labeled correctly?
[ ] If template updates: do they align with developers.google.com/style/?
[ ] Did the PR receive at least one :+1: and no :-1: from core-maintainers?
[ ] On merging, did you complete the merge using keywords?
[ ] On merging, did you add any applicable notes to a draft release and link to this PR?

Loquacity commented 3 years ago

@mgan59 I think the action won't run because I've proposed from a fork, rather than a direct branch. Can we adjust the action so that works, or is this a limitation of GH Actions?

Loquacity commented 3 years ago

@mgan59 I think the action won't run because I've proposed from a fork, rather than a direct branch. Can we adjust the action so that works, or is this a limitation of GH Actions?

I might have answered my own question. According to https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/ I need to change the action to run on: [pull_request_target]. Let me try that.

Loquacity commented 3 years ago

I don't have the time to handle this right now, sorry. Feel free to close it. If someone wants to take these images and add them to the new site, I'm happy for them to do so.

camerons commented 3 years ago

This is a good first time issue for someone who wants to learn how to use git. Look at these changes that Loquacity has recommended in this legacy repository thegooddocsproject.github.io and copy the changes across to https://github.com/thegooddocsproject/website-hugo

thegooddocsproject / thegooddocsproject.github.io